Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove the need to call set_manager to set up #130

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 31, 2025

This makes it a bit easier to use outside of ha since everything can be set up with

await habluetooth.BluetoothManager().async_setup()

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (70b2f69) to head (125f95b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/habluetooth/manager.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   83.97%   83.84%   -0.13%     
==========================================
  Files          12       12              
  Lines        1198     1201       +3     
  Branches      138      139       +1     
==========================================
+ Hits         1006     1007       +1     
- Misses        144      145       +1     
- Partials       48       49       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #130 will not alter performance

Comparing setup_onecall (125f95b) with main (70b2f69)

Summary

✅ 3 untouched benchmarks

@bdraco bdraco merged commit 1312bf7 into main Jan 31, 2025
23 of 25 checks passed
@bdraco bdraco deleted the setup_onecall branch January 31, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant