Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up marshalling variants #86

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 8, 2022

This is roughly a 3% speed up marshalling most messages

This is pre-work for optimizing write_array in #84

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

Base: 81.42% // Head: 81.36% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (7f4d270) compared to base (07e6886).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   81.42%   81.36%   -0.06%     
==========================================
  Files          25       25              
  Lines        2928     2930       +2     
  Branches      566      566              
==========================================
  Hits         2384     2384              
- Misses        335      337       +2     
  Partials      209      209              
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/_private/marshaller.py 98.26% <100.00%> (+0.03%) ⬆️
src/dbus_fast/message_bus.py 72.43% <0.00%> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco merged commit 7847e26 into main Oct 8, 2022
@bdraco bdraco deleted the speed_up_marsh_single branch October 8, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant