Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure proxy object tasks do not get garbage collected prematurely #409

Merged
merged 9 commits into from
Mar 7, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 6, 2025

There was a task that did not have a strong reference held

fixes #388

Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (5068e41) to head (14eead0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
+ Coverage   84.24%   84.44%   +0.19%     
==========================================
  Files          28       28              
  Lines        3390     3394       +4     
  Branches      600      600              
==========================================
+ Hits         2856     2866      +10     
+ Misses        334      329       -5     
+ Partials      200      199       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #409 will not alter performance

Comparing proxy_task (14eead0) with main (5068e41)

Summary

✅ 3 untouched benchmarks

@bdraco bdraco marked this pull request as ready for review March 7, 2025 00:08
@bdraco bdraco merged commit 4fcdbed into main Mar 7, 2025
21 of 22 checks passed
@bdraco bdraco deleted the proxy_task branch March 7, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy_object can create tasks without holding a strong reference
1 participant