Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade typing on private modules #402

Merged
merged 2 commits into from
Mar 5, 2025
Merged

chore: upgrade typing on private modules #402

merged 2 commits into from
Mar 5, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 5, 2025

No description provided.

Copy link

codspeed-hq bot commented Mar 5, 2025

CodSpeed Performance Report

Merging #402 will not alter performance

Comparing upgrade_typing (b2c1b07) with main (dc3d8e7)

Summary

✅ 3 untouched benchmarks

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.11%. Comparing base (dc3d8e7) to head (b2c1b07).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/dbus_fast/_private/util.py 80.00% 2 Missing and 1 partial ⚠️
src/dbus_fast/_private/address.py 50.00% 1 Missing ⚠️
src/dbus_fast/_private/unmarshaller.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   83.98%   84.11%   +0.13%     
==========================================
  Files          28       29       +1     
  Lines        3390     3394       +4     
  Branches      605      603       -2     
==========================================
+ Hits         2847     2855       +8     
+ Misses        337      333       -4     
  Partials      206      206              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bdraco bdraco merged commit 640e1f8 into main Mar 5, 2025
21 checks passed
@bdraco bdraco deleted the upgrade_typing branch March 5, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant