This repository has been archived by the owner on Nov 30, 2018. It is now read-only.
Dialog: Fix height issues when calling reposition #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where if reposition is called more than once, the height of the dialog is changed and affects the calculations such that for dialogs that exceed the window height, vertical scrollbars are removed erroneously.
TommiGustafsson
added a commit
to TommiGustafsson/Durandal
that referenced
this pull request
Sep 18, 2014
|
Thanks for the fix. I updated my pull request #578 with your fix. It is better and simpler than what I wrote. |
|
Landed in branch Next-Version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where if reposition is called more than once, the height of the dialog is changed on the first call and affects the calculations in subsequent calls such that for dialogs that exceed the window height, vertical scrollbars are removed erroneously.