Add link component #262
Merged
Add link component #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 29, 2019 11:17
Now user interactions (clicks so far) will be handled in outer scope. This way we can define custom logic for web components. Current implementation will emit custom events when user clicks links instead of changing current route
kenjinp
approved these changes
Aug 29, 2019
kenjinp
suggested changes
Aug 29, 2019
Done, now component will call event's preventDefault. |
kenjinp
approved these changes
Aug 29, 2019
kenjinp
added a commit
that referenced
this pull request
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now user interactions (clicks so far) will be handled in outer scope.
This way we can define custom logic for web components.
Current implementation will emit custom events when user clicks links
instead of changing current route