This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Skip download for arXiv articles with broken ID or version #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #585.
Description
This PR fixes the CLI download error caused by arXiv papers with broken ID or version. See comments to #585 for details.
The solution implemented here is to simply skip such problematic papers. This is consistent with the fact that also arXiv cannot retrieve such articles (see e.g. https://arxiv.org/pdf/1808.02949v1.pdf).
How to test?
Please provide here instructions on how to test the changes introduced by this PR.
(if some changes cannot be tested by automated tests)
Checklist
(if it is not the case, please create an issue first).
(if needed)
(if a function is added or modified)