-
Notifications
You must be signed in to change notification settings - Fork 12
Add the TopicInfo data structure #542
Add the TopicInfo data structure #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice 🎉 It is definitely more clear and clean than copy-pasting the dictionary for every source, thanks for the changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very reasonable! Thank you for the effort:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work @Stannislav Stan!
It will definitely make our code simpler to maintain and understand!
Co-authored-by: Francesco Casalegno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
Fixes #539 .
Description
This adds the
TopicInfo
data class that replaces the manual creation and copy-pasting of the structured dictionary that we have been using for this purpose so far.How to test?
tests/unit/database/test_topic_info.py
Checklist
(if it is not the case, please create an issue first).
(if needed)
whatsnew.rst
updated.(if needed)
setup.py
andrequirements.txt
updated with new dependencies.(if needed)
(if a function is added or modified)