Fix location if section list is empty #451
Conversation
| self.sec_index = int(np.argmax(np.linalg.norm(points, axis=1))) | ||
| else: | ||
| self.sec_index = int(np.argmax(points.dot(self.direction))) | ||
| if len(points) > 0: |
There was a problem hiding this comment.
But what will happen if this fails? Isn't that an exception?
There was a problem hiding this comment.
yes, here: https://github.com/BlueBrain/BluePyOpt/blob/master/bluepyopt/ephys/locations.py#L432
as sec_index =None (default) value I didn't bother raising the same again
There was a problem hiding this comment.
I was almost gonna say it was ok like this. But then I realized that this function is called set_sec_index. The user of this method would expect something to happen to sec_index when it is being called. (Let's say e.g. sec_index was set to a certain value before the call, it would not even set to None again if no points were found). I think an exception here is the safest, because in the end ... it is an exception ;-)
There was a problem hiding this comment.
sure, better like that?
No description provided.