Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schemas when registering / updating nexus resources #168

Merged
merged 11 commits into from
Sep 12, 2024
Merged

Conversation

AurelienJaquier
Copy link
Collaborator

  • add 'analysis suitable' notation
  • refactor adding images to resources
  • new function to update an EModel resource with images
  • update an emodel with images after plotting in luigi pipeline when access point is nexus
  • update emodel after validation instead of deprecating it and re-registering it (it was messing with emodel ids)

Jaquier Aurélien Tristan added 7 commits September 9, 2024 08:58
Change-Id: I2c0c15edeb32b915a40bff99a2def6f6a1fc9b7a
Change-Id: I03409653e89d7730a75d55316372b776ed3fc639
Change-Id: Ia8150f00c6352fe9c6d26866e8511611574a0e5e
…ring it

Change-Id: Id33ad7111f51e38514be390cb4630bd330a5836c
Change-Id: I139430ea0d2ee426f539a6e2efd0ae0ee95b28d8
Change-Id: I7f6ff430583ef302e269b27916242e0821dd3eca
Change-Id: Iad650cd38bdcdc475c468f60384f6e9734bc7407
@AurelienJaquier AurelienJaquier self-assigned this Sep 12, 2024
Change-Id: I533a29b95b5da74626f3e6d7afe390861e2318ba
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 22.89157% with 64 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (8d5b0ab) to head (9d17a3f).
Report is 82 commits behind head on main.

Files with missing lines Patch % Lines
bluepyemodel/access_point/nexus.py 6.66% 42 Missing ⚠️
bluepyemodel/access_point/forge_access_point.py 6.25% 15 Missing ⚠️
bluepyemodel/tasks/emodel_creation/optimisation.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   60.07%   52.50%   -7.58%     
==========================================
  Files         109      124      +15     
  Lines        7838    10416    +2578     
==========================================
+ Hits         4709     5469     +760     
- Misses       3129     4947    +1818     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jaquier Aurélien Tristan added 2 commits September 12, 2024 14:23
Change-Id: I5f6a8f2100c5c99b98ff6ccee133213ecc6e75f6
Change-Id: If37ea22d07ca711fcf16c1c2b3163d3ed90992f1
Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you

Change-Id: Idb17c1de2fdacf84dbaeeed04b8587db9dc1f61a
@AurelienJaquier AurelienJaquier merged commit eaa9e43 into main Sep 12, 2024
6 checks passed
@AurelienJaquier AurelienJaquier deleted the schemas branch September 12, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants