Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg_resources to importlib_resources #139

Merged
merged 6 commits into from
May 16, 2024
Merged

Migrate pkg_resources to importlib_resources #139

merged 6 commits into from
May 16, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented May 15, 2024

No description provided.

@ilkilic ilkilic self-assigned this May 15, 2024
@ilkilic ilkilic requested a review from AurelienJaquier May 15, 2024 12:11
@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 59.68%. Comparing base (a099656) to head (9ad5456).
Report is 30 commits behind head on main.

Files Patch % Lines
bluepyemodel/tools/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   59.33%   59.68%   +0.35%     
==========================================
  Files         106      108       +2     
  Lines        7738     7803      +65     
==========================================
+ Hits         4591     4657      +66     
+ Misses       3147     3146       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

setup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@ilkilic ilkilic merged commit 11275af into main May 16, 2024
7 checks passed
@ilkilic ilkilic deleted the migrate-pkg branch May 16, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants