Skip to content

Commit

Permalink
remove stale extract_config from workflow
Browse files Browse the repository at this point in the history
Change-Id: Iab4e5ec6a9f26b9a7d3b7bf51bdb21c3ff413634
  • Loading branch information
Jaquier Aurélien Tristan committed Oct 10, 2023
1 parent 4f0eabe commit f12e89b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 10 deletions.
4 changes: 0 additions & 4 deletions bluepyemodel/tasks/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class EmodelAPIConfig(luigi.Config):
recipes_path = luigi.OptionalParameter(default=None)
final_path = luigi.OptionalParameter(default="./final.json")
legacy_dir_structure = luigi.BoolParameter(default=False)
extract_config = luigi.OptionalParameter(default=None)

# nexus parameters
forge_path = luigi.OptionalParameter(default=None)
Expand All @@ -45,15 +44,12 @@ def __init__(self, *args, **kwargs):
if self.api == "local":
if self.recipes_path is None:
raise ValueError("recipes_path cannot be None when api is set to 'local'")
if self.extract_config is None:
raise ValueError("extract_config cannot be None when api is set to 'local'")

self.api_args = {
"emodel_dir": self.emodel_dir,
"recipes_path": self.recipes_path,
"final_path": self.final_path,
"legacy_dir_structure": self.legacy_dir_structure,
"extract_config": self.extract_config,
}

if self.api == "nexus":
Expand Down
9 changes: 3 additions & 6 deletions bluepyemodel/tasks/emodel_creation/optimisation.py
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,7 @@ def remote_script(self):
'{"emodel_dir": None',
'"recipes_path": None',
'"final_path": None',
'"legacy_dir_structure": None',
'"extract_config": None}',
'"legacy_dir_structure": None}',
)
),
type=json.loads,
Expand Down Expand Up @@ -611,8 +610,7 @@ def remote_script(self):
'{"emodel_dir": None',
'"recipes_path": None',
'"final_path": None',
'"legacy_dir_structure": None',
'"extract_config": None}',
'"legacy_dir_structure": None}',
)
),
type=json.loads,
Expand Down Expand Up @@ -780,8 +778,7 @@ def remote_script(self):
'{"emodel_dir": None',
'"recipes_path": None',
'"final_path": None',
'"legacy_dir_structure": None',
'"extract_config": None}',
'"legacy_dir_structure": None}',
)
),
type=json.loads,
Expand Down

0 comments on commit f12e89b

Please sign in to comment.