Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generator: Save a fe_mul in shallue_van_de_woestijne #277

Closed
wants to merge 1 commit into from
Closed

generator: Save a fe_mul in shallue_van_de_woestijne #277

wants to merge 1 commit into from

Conversation

real-or-random
Copy link
Collaborator

No description provided.

@real-or-random real-or-random mentioned this pull request Nov 17, 2023
Merged
@roconnor-blockstream
Copy link
Contributor

Arguably this whole function should be rewritten. Unfortunately that is risky, so maybe it is better to keep doing these micro-improvements.

roconnor-blockstream
roconnor-blockstream approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@roconnor-blockstream roconnor-blockstream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I ran some randomized testing comparing this to my Haskell implementation.

@real-or-random
Copy link
Collaborator Author

Arguably this whole function should be rewritten. Unfortunately that is risky, so maybe it is better to keep doing these micro-improvements.

You have a point, though. I mean, sure, let's merge this if we get the ACKs, but a proper rewrite is probably a better approach.

@real-or-random
Copy link
Collaborator Author

Haskell implementation.

Is that a full implementation of the SWU map? I guess we could then steal the algorithm.

@roconnor-blockstream roconnor-blockstream mentioned this pull request Jan 12, 2024
Closed
@roconnor-blockstream
Copy link
Contributor

See #286 for my rewrite of this function, which would supersede this PR.

@jonasnick jonasnick closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roconnor-blockstream roconnor-blockstream roconnor-blockstream approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@real-or-random @roconnor-blockstream @jonasnick