CI: Do not install path-deps in python-builder
#442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `python-builder` is the first stage when building the Dockerfile. It installs all python dependencies into a `venv`. Installing dependencies is time-consuming and we want to cache this. Therefore, we don't want to include the path-dependencies yet. If we would add `gl-client` and `gl-testing` we would have to rebuild the entire docker container every time we change a line in the code-base. In the `python-builder` we first generate a list of dependencies using `poetry export`. We filter out the path-dependencies of this list before installing them. However, the script to filter out the path-dependencies is broken. We fail to filter out the path-dependencies. This modification fixes the problem and ensures the pipeline runs again.
|
The error message given by poetry is a bit tricky. It hints to a problem with verifying the hashes. This is an alternative to the |
cdecker
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
python-builderis the first stage when building the Dockerfile.It installs all python dependencies into a
venv.Installing dependencies is time-consuming and we want to cache this.
Therefore, we don't want to include the path-dependencies yet. If we
would add
gl-clientandgl-testingwe would have to rebuild theentire docker container every time we change a line in the code-base.
In the
python-builderwe first generate a list of dependencies usingpoetry export. We filter out the path-dependencies of this list beforeinstalling them.
However, the script to filter out the path-dependencies is broken. We
fail to filter out the path-dependencies. This modification fixes the
problem and ensures the pipeline runs again.