General improvements and fixes. #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- invalidate the refresh timer whenever we go to the installer to keep tasks minimal - make the env and lightning config dynamic - add lightning http hidden service to standup.command - add configuration script for lightning and the http plugin
- now will successfully install and configure c-lightning for QuickConnect
- reckless, unfairly cheap, ludicrously fast
- fix QuickConnect bug for c-lightning - install latest tagged release 0.9.1 for c-lightning - try and reduce the rainbow spinner when install scripts complete, not sure what is going on here... - ensure the log is deleted when standing down - force remove .standup directory when using the kill switch - fix creation of hidden services for lightning in standup.command script - fix typo on rpcwhitelist - add an updated dmg
… installing lightning the first time fix: refresh home page when build scripts complete
…andup directory and opening via the console app fix: add reckless button for c-lightning fix: cut off text on authentication prompt
… install, automatically start tor when standup.sh completes to prevent issues where hidden services do not get created if the user does not start Tor, hide c-lightning unless tor is running and Bitcoin Core is running, only attempt to start lightning if the node is fully synced, stope showing Tor V3 auth prompt as it confuses people, hide c-lightning
…unch Tor which means the console should dismiss just fine
ChristopherA
requested changes
Oct 11, 2020
There was a problem hiding this comment.
Tested NACK: Built on macOS Catalina (10.15.6) (inside VMware 11.5.6) using Xcode 11.7. Tested using VM with pruned full node created by previous Gordian Server #54
cd GordianServer-macOS
git pull --ff-only
git clean --ffdx
gh pr checkout 61
git clean --ffdx
rm -Rf ~/.standup
rm -Rf ~/.lightning
open XCode/GordianServer-macOS.xcodeproj
Standup was requested and approved, and on completion Gordian Server showed pruned full node and status of fully synced.
I let it sit for a while, but Gordian Server crashed while I wasn't looking, with
Exception NSException * "launch path not accessible" 0x0000600000d74fc0
name __NSCFConstantString * "NSInvalidArgumentException" 0x00007fff86dda4a0
reason __NSCFConstantString * "launch path not accessible" 0x00007fff872b31d8
userInfo void * NULL 0x0000000000000000
reserved __NSDictionaryM * 2 key/value pairs 0x000060000c3a8d40
This happened in thread:
libsystem_kernel.dylib`__pthread_kill:
0x7fff69431330 <+0>: movl $0x2000148, %eax ; imm = 0x2000148
0x7fff69431335 <+5>: movq %rcx, %r10
0x7fff69431338 <+8>: syscall
-> 0x7fff6943133a <+10>: jae 0x7fff69431344 ; <+20>
0x7fff6943133c <+12>: movq %rax, %rdi
0x7fff6943133f <+15>: jmp 0x7fff6942b629 ; cerror_nocancel
0x7fff69431344 <+20>: retq
0x7fff69431345 <+21>: nop
0x7fff69431346 <+22>: nop
0x7fff69431347 <+23>: nop
in the log window:
error:
script: IsLightningInstalled
2020-10-11 00:19:08.262329-0700 GordianServer-macOS[29033:79744] [General] An uncaught exception was raised
2020-10-11 00:19:08.263890-0700 GordianServer-macOS[29033:79744] [General] launch path not accessible
2020-10-11 00:19:08.264289-0700 GordianServer-macOS[29033:79744] [General] (
0 CoreFoundation 0x00007fff2f503be7 __exceptionPreprocess + 250
1 libobjc.A.dylib 0x00007fff681425bf objc_exception_throw + 48
2 Foundation 0x00007fff31bc3fdd -[NSConcreteTask launchWithDictionary:error:] + 5213
3 GordianServer-macOS 0x00000001000701dd $s19GordianServer_macOS14ViewControllerC9runScript33_BDE91E532C2BCB3691C9B986908EAADALL6scriptyAA6SCRIPTO_tFyycfU_ + 1629
4 GordianServer-macOS 0x000000010000aa50 $sIeg_IeyB_TR + 48
5 libdispatch.dylib 0x000000010045b844 _dispatch_call_block_and_release + 12
6 libdispatch.dylib 0x000000010045c826 _dispatch_client_callout + 8
7 libdispatch.dylib 0x0000000100470573 _dispatch_root_queue_drain + 816
8 libdispatch.dylib 0x0000000100470e03 _dispatch_worker_thread2 + 127
9 libsystem_pthread.dylib 0x00000001004ea31b _pthread_wqthread + 220
10 libsystem_pthread.dylib 0x00000001004e949b start_wqthread + 15
)
2020-10-11 00:19:08.265844-0700 GordianServer-macOS[29033:79744] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'launch path not accessible'
*** First throw call stack:
(
0 CoreFoundation 0x00007fff2f503be7 __exceptionPreprocess + 250
1 libobjc.A.dylib 0x00007fff681425bf objc_exception_throw + 48
2 Foundation 0x00007fff31bc3fdd -[NSConcreteTask launchWithDictionary:error:] + 5213
3 GordianServer-macOS 0x00000001000701dd $s19GordianServer_macOS14ViewControllerC9runScript33_BDE91E532C2BCB3691C9B986908EAADALL6scriptyAA6SCRIPTO_tFyycfU_ + 1629
4 GordianServer-macOS 0x000000010000aa50 $sIeg_IeyB_TR + 48
5 libdispatch.dylib 0x000000010045b844 _dispatch_call_block_and_release + 12
6 libdispatch.dylib 0x000000010045c826 _dispatch_client_callout + 8
7 libdispatch.dylib 0x0000000100470573 _dispatch_root_queue_drain + 816
8 libdispatch.dylib 0x0000000100470e03 _dispatch_worker_thread2 + 127
9 libsystem_pthread.dylib 0x00000001004ea31b _pthread_wqthread + 220
10 libsystem_pthread.dylib 0x00000001004e949b start_wqthread + 15
)
libc++abi.dylib: terminating with uncaught exception of type NSException
(lldb)
It looks like maybe there is still some lighting related code executing in here, but crashing because it is partially disabled.
-- Christopher Allen
|
@ChristopherA c843de5 should fix this issue. |
ChristopherA
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.