Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-Lightning #60

Merged
merged 17 commits into from
Oct 20, 2020
Merged

C-Lightning #60

merged 17 commits into from
Oct 20, 2020

Conversation

Fonta1n3
Copy link
Contributor

@Fonta1n3 Fonta1n3 commented Oct 8, 2020

No description provided.

- invalidate the refresh timer whenever we go to the installer to keep tasks minimal
- make the env and lightning config dynamic
- add lightning http hidden service to standup.command
- add configuration script for lightning and the http plugin
 - now will successfully install and configure c-lightning for QuickConnect
- reckless, unfairly cheap, ludicrously fast
- fix QuickConnect bug for c-lightning
- install latest tagged release 0.9.1 for c-lightning
- try and reduce the rainbow spinner when install scripts complete, not sure what is going on here...
- ensure the log is deleted when standing down
- force remove .standup directory when using the kill switch
- fix creation of hidden services for lightning in standup.command script
- fix typo on rpcwhitelist
- add an updated dmg
… installing lightning the first time

fix: refresh home page when build scripts complete
…andup directory and opening via the console app

fix: add reckless button for c-lightning

fix: cut off text on authentication prompt
… install, automatically start tor when standup.sh completes to prevent issues where hidden services do not get created if the user does not start Tor, hide c-lightning unless tor is running and Bitcoin Core is running, only attempt to start lightning if the node is fully synced, stope showing Tor V3 auth prompt as it confuses people, hide c-lightning
@ChristopherA
Copy link
Contributor

Ok, this PR builds ok on my VM. I deleted ~/.standup and ~/.lightning from #54, and so when I ran Gordian Server is asked for standup. This worked, and since this VM already has the pruned node from the last GS, clicking on Start downloaded just a few missing blocks, and then said "fully synced".

I then clicked on #Reckless, until the installation was done. As usual, I had to do a force-quit. When I restarted GS, the #Reckless button is now Start. However, after clicking it a few messages show at top of screen, but then it stops with no error, like #54 did. You can click refresh and Start again, but again nothing, no error.

Looking at Lightning Log, I see:

2020-10-11T06:56:01.473Z UNUSUAL lightningd: Creating configuration directory /Users/admin/.lightning/bitcoin
2020-10-11T06:56:01.484Z DEBUG   plugin-manager: started(24226) /Users/admin/.standup/lightning/lightningd/../plugins/autoclean
2020-10-11T06:56:01.491Z DEBUG   plugin-manager: started(24227) /Users/admin/.standup/lightning/lightningd/../plugins/bcli
2020-10-11T06:56:01.534Z DEBUG   plugin-manager: started(24228) /Users/admin/.standup/lightning/lightningd/../plugins/keysend
2020-10-11T06:56:01.544Z DEBUG   plugin-manager: started(24229) /Users/admin/.standup/lightning/lightningd/../plugins/pay
2020-10-11T06:56:01.549Z DEBUG   plugin-manager: started(24230) /Users/admin/.standup/lightning/lightningd/../plugins/txprepare
2020-10-11T06:56:01.553Z DEBUG   plugin-manager: started(24231) /Users/admin/.standup/lightning/lightningd/../plugins/spenderp
2020-10-11T06:56:01.559Z DEBUG   plugin-manager: started(24232) /Users/admin/.lightning/plugins/c-lightning-http-plugin/target/release/c-lightning-http-plugin
2020-10-11T06:56:03.420Z INFO    database: Creating database
2020-10-11T06:56:03.448Z UNUSUAL hsmd: HSM: created new hsm_secret file
2020-10-11T06:56:03.622Z INFO    plugin-bcli: bitcoin-cli initialized and connected to bitcoind.
2020-10-11T06:56:03.633Z UNUSUAL lightningd: Unable to estimate opening fees
2020-10-11T06:56:03.633Z UNUSUAL lightningd: Unable to estimate mutual_close fees
2020-10-11T06:56:03.633Z UNUSUAL lightningd: Unable to estimate unilateral_close fees
2020-10-11T06:56:03.633Z UNUSUAL lightningd: Unable to estimate delayed_to_us fees
2020-10-11T06:56:03.633Z UNUSUAL lightningd: Unable to estimate htlc_resolution fees
2020-10-11T06:56:03.633Z UNUSUAL lightningd: Unable to estimate penalty fees
2020-10-11T06:56:03.633Z UNUSUAL lightningd: Unable to estimate min_acceptable fees
2020-10-11T06:56:03.633Z UNUSUAL lightningd: Unable to estimate max_acceptable fees
2020-10-11T06:56:03.651Z UNUSUAL plugin-bcli: /Users/admin/.standup/BitcoinCore/bitcoin-0.20.1/bin/bitcoin-cli -datadir=/Users/admin/Library/Application Support/Bitcoin -rpcuser=... -rpcpassword=... getblock 0000000000000000000d67a326ab681a0f2d91a26e46aca1dd60f7a269a5dad6 0 exited with status 1

That last line is repeated 20+ times, then it does the "unable to estimate open fees" section agagain, then end with the same "UNUSUAL plugin-bcli" error 20+ times. This go on over and over.

The lightning .config is (deleting password):

alias=Gordian-Server
bitcoin-rpcpassword=rZsWw8iL3tP4iudpSFwsg5VD4oCV6zZ8
bitcoin-rpcuser=ow3M1sBKyH
bitcoin-cli=/Users/admin/.standup/BitcoinCore/bitcoin-0.20.1/bin/bitcoin-cli
bitcoin-datadir=/Users/admin/Library/Application Support/Bitcoin
network=bitcoin
plugin=/Users/admin/.lightning/plugins/c-lightning-http-plugin/target/release/c-lightning-http-plugin
proxy=127.0.0.1:9050
announce-addr=qbjj66jtalrtbj4beibparkfdysbnte6b77isv3kim4tq4jmmgqkwcid.onion
bind-addr=127.0.0.1:9735
log-file=/Users/admin/.lightning/lightning.log
log-level=debug:plugin
http-pass=PASSWORD
http-port=1312

Enclosed is the full standup log for the install of this PR.

-- Christopher Allen
2020-10-11 PR 80 Standup.log

@Fonta1n3
Copy link
Contributor Author

Ah yea, pruned nodes need to run for awhile for estimatesmartfee to work which lightning relies on. Can add an additional check that command returns a valid response before actually attempting to start lightning.

@Fonta1n3
Copy link
Contributor Author

Hey @ChristopherA I have just added an additional check so that a user is better informed as to why they can not yet use lightning. Basically pruned nodes need some time to gather the mempool fee market to utilize bitcoin-cli estimatesmartfee (which c-lightning relies on), so we now make that command when a user goes to start lightning and if it fails show the appropriate warning and do not start.

I tested this from scratch and it works fine for me.

You need to test this on a fully synced mainnet node.

@Fonta1n3 Fonta1n3 merged commit ac4b021 into BlockchainCommons:c-lightning Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants