rpcauth #169
Merged
rpcauth #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ping bitcoin core (not a script) To do: use http in app delegate for quitting bitcoin core. Handle missing rpcauth in existing bitcoin.conf on an adhoc basis. Different classifications of rpcwhitelist (e.g. GordianServer user does not need them all but FullyNoded does). rpcauth for quickconnect 2.0. add python3 framework for m1 to avoid rosetta crashes.
refactor: use swit code instead of scripts where possible fix: bug where editing settings would launch two install prompts fix: better UX when bitcoin is installed the first time
|
Why closed? |
Seems there was no interest and I wanted to make more commits and not have them show up here. Can add back again. |
|
Hey this fixes the update issue #180 |
|
incorporating into dev branch for testing. |
|
Unfortunately, the PR doesn't work. Trying it out on a M1 machine where I cleaned out the files with KILLALL: No buttons at all are illuminated. (So not only can you not START or STOP, but VERIFY is gray too, as is the network choice.) Bitcoin 25 update was also not allowed to minimize variables. == Trying it out on an older (non-M1) machine where the directory was still in place:
The START and STOP buttons are not available, though I think Bitcoin is running, as Server later asked if it should be left running when I killed Server. rpc host is unauthenticated. This was AFTER allowing the Bitcoin 25 update, which also didn't work right (I had to close out the install window after installation, and then restart the Server.) == If I was going to dig into this more my process would be:
|
|
I have not tested this on a fresh install (recently)... it's a 2 year old PR. I've been using this for 2 years without any issues, will try and delete Gordian directory and see if I can replicate your issue. Keep in mind this has nothing do with with the RPC authentication for the tor hidden service. It just replaces the need for storing rpc creds in plain text in your bitcoin.conf |
|
fwiw I deleted the .gordian directory and it installed for me without any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpcauthinstead of plain text rpc credentialsrpcuserandrpcpasswordcan still be used but as far as Gordian Server is concerned it will only check forrpcauth=GordianServer:xxxx, if theGordianServeruser has not been added it automatically generates its ownrpcauthcreds and adds them to thebitcoin.confrpcauth.py, Python can be removed with a simple file that translatesrpcauth.pyto Swift, however embedding python allows us to do some interesting things for future extensibility like integrating Join Market in its entirety as a native macOS app, c-lightning also has Python related codeDisable Library Validationunder theHardened Runtimecapability in Xcode: