-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portable Mode - Dummy File (amiberry.portable) to indicate defaulting to local folder structure/relative paths #1527
Comments
I actually touched on this in an EAB post ; I saw it as a compile time aspect .... I'm unsure as to what the 'proper' resolution is here ;) |
Check for the existence of a file named "amiberry.portable" in the current directory, when starting up. If found, switch to portable mode, expecting all related directories under the current dir.
@RodimusFVC |
Sure, I'll give it a quick compile and test on my main machine today. |
Tested the following :
Things I noticed and would like your opinion on:
Everything else works as expected and seem perfect! :) If you want to ignore or track these other two items separately, I can close this issue, or we can fix them in this stream.. or ignore them. Up to you! |
The reason I suggested this solution was due to this being used by several other tools that I've used in the past - this also means that you don't have to recompile to gain the benefits of this behavior. Many people will simply use the packaged version, but if you had a zipped copy - then it just simply works. For me, the way I copy Amiberry around from device to device (wherever I'm currently working gets the latest copy) - having this portability is a lifesaver. :) |
In portable mode, there's no guarantee the conf dir will exist, so make sure it's created in that case.
I've updated the branch, with logic to create the Regarding relative paths: not such a simple change, as much of the code related to that comes from WinUAE, and I'm trying to keep things in-sync between the two projects, so merges can be easier. I think we'll leave that for later. |
Fair enough. I've always wondered why WinUAE did that, considering it also supports portable installations. I had to manually edit the configs every time... so I'm used to doing it. I'll close this out! :) Thanks midwan! |
Wiki updated accordingly also: https://github.com/BlitterStudio/amiberry/wiki/Amiberry-directories |
* enhancement: added portable mode detection (fixes #1527) Check for the existence of a file named "amiberry.portable" in the current directory, when starting up. If found, switch to portable mode, expecting all related directories under the current dir. * create config dir if it doesn't exist (#1527) In portable mode, there's no guarantee the conf dir will exist, so make sure it's created in that case.
Per our discussion in Discord -
Having a flag file to cause a defaulting of behavior to a full portable mode without the need for environment variables, creation of additional paths/confs in the home folder, etc.
If this means moving the amiberry.conf file out of the /data folder and under the binary, that's fine too. As long as I can drop the folder anywhere and click and go - this is a satisfied requirement.
The text was updated successfully, but these errors were encountered: