Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ownCloud Music #66

Merged
merged 2 commits into from
May 7, 2022
Merged

Support for ownCloud Music #66

merged 2 commits into from
May 7, 2022

Conversation

rstefko
Copy link

@rstefko rstefko commented May 5, 2022

ownCloud Music does not provide path, but this plugin seems to rely on it. So when path is not available there is additional code that builds the path.
I am not sure how it works with other Subsonic servers, so maybe the code changes are note appropriate.
Also playlists still does not work.

@paulijar
Copy link

paulijar commented May 5, 2022

Note that according to the Subsonic XML schema http://www.subsonic.org/pages/inc/api/schema/subsonic-rest-api-1.16.1.xsd, the attribute path is optional. Hence, the clients should not assume that it would always exist.

It would be trivial to make the ownCloud Music include the path attribute in its responses so that it would contain only the file name. But including the full path would be much more difficult and could introduce performance issues; this is due the underlying design of the ownCloud file system.

@midwan midwan self-assigned this May 7, 2022
@midwan
Copy link
Collaborator

midwan commented May 7, 2022

Thanks!

@midwan midwan merged commit 208376a into BlitterStudio:master May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants