Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sm): cleanup #83

Merged
merged 2 commits into from
Oct 30, 2024
Merged

chore(sm): cleanup #83

merged 2 commits into from
Oct 30, 2024

Conversation

ddaoxuan
Copy link
Collaborator

@ddaoxuan ddaoxuan commented Oct 28, 2024

  • move non-mutable functions away from actions to clients
  • modify meilisearch search functionality, to decrease amount of requests sent in a single cycle, running const index = await client.getIndex() is additional query whilst client.index.search is just 1
  • fixes gh actions by changing naming convention for env variables

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
enterprise-commerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 0:04am

Copy link

Next.js Bundle Analysis (shopify-meilisearch)

📦 Next.js Bundle Analysis for blazity-shopify-meilisearch-starter

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 85.02 KB (🟢 -40 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Ten Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/layout 88.95 KB (🟢 195 B) 173.97 KB
/settings/page 42.55 KB (🟢 -59 B) 127.57 KB
/category/plp/[slug]/page 62.93 KB (-6 B) 147.94 KB
/category/clp/[slug]/page 62.93 KB (-6 B) 147.94 KB
/home/[bucket]/page 11.81 KB (🟢 -16.28 KB) 96.82 KB
/favorites/page 11.81 KB (🟢 3 B) 96.82 KB
/product/[slug]/draft/page 47.29 KB (🟢 171 B) 132.3 KB
/product/[slug]/page 51.28 KB (🟢 299 B) 136.3 KB
/category/clp/[slug]/[page]/page 62.93 KB (-6 B) 147.94 KB
/search/page 62.93 KB (-6 B) 147.94 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by undefined% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@ddaoxuan ddaoxuan merged commit 727dec8 into main Oct 30, 2024
10 checks passed
@ddaoxuan ddaoxuan deleted the ddao/cleanup branch October 30, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant