feat: ui changes #81
Merged
feat: ui changes #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ddaoxuan
reviewed
Oct 22, 2024
| ) | ||
| } | ||
|
|
||
| function FacebookIcon(props: React.SVGProps<SVGSVGElement>) { | ||
| function FacebookIcon(props) { |
There was a problem hiding this comment.
what's the reason to remove types?
There was a problem hiding this comment.
I probably formatted something with the chatbot and had to delete it. I fixed it.
|
|
||
| export async function CategoriesSection() { | ||
| const categories = await getCategories() | ||
| export async function CategoriesSection({ categories }: { categories: Pick<PlatformCollection, "handle" | "title" | "id" | "image">[] }) { |
There was a problem hiding this comment.
This component could just fetch categories on its own
starters/shopify-meilisearch/views/product/product-added-alert.tsx
Outdated
Show resolved
Hide resolved
starters/shopify-meilisearch/views/product/product-added-alert.tsx
Outdated
Show resolved
Hide resolved
Next.js Bundle Analysis (shopify-algolia)📦 Next.js Bundle Analysis for blazity-shopify-algolia-starterThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Co-authored-by: Dawid Dao Xuan <[email protected]>
Co-authored-by: Dawid Dao Xuan <[email protected]>
Co-authored-by: Dawid Dao Xuan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.