GET_FIELD_TESTS #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, implementation of new methods in XI5250Field.class were needed.
rabelenda
suggested changes
Apr 22, 2019
|
|
||
| private List<TestField> buildExpectedFields() { | ||
| List<TestField> testFieldList = new ArrayList<>(); | ||
| testFieldList.add((new TestField(new TestField.FieldBuilder(FIELD_STRING_OUTPUT).withAttr(36).withDefaultColumn().withRow(5)))); |
There was a problem hiding this comment.
in general the builder pattern should look more like new TestField.FieldBuilder()......build() and not as a new inside another. Please implement build method on builder and use that instead to make code a little shorter, better encapsulated, and mor obvious. Additionally, I think you have an unnecessary pair of parenthesis in this expression.
| return this; | ||
| } | ||
|
|
||
| FieldBuilder withAttr(int val) { |
There was a problem hiding this comment.
indentation doesn't look consisten, please re format the entire file to avoid such issues.
|
|
||
| } | ||
| @Override | ||
| public String toString() { |
| ", text='" + text + '\'' + | ||
| '}'; | ||
| } | ||
| @Override |
|
|
||
|
|
||
| } | ||
| private static class ExceptionWaiter implements ExceptionHandler { |
|
|
||
|
|
||
|
|
||
|
|
Additionally, add missing java doc to TerminalClient.getFields method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.