Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use maintained Docker baseimage #1

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Use maintained Docker baseimage #1

merged 1 commit into from
Feb 9, 2022

Conversation

peterrus
Copy link
Contributor

@peterrus peterrus commented Feb 5, 2022

With the intention of letting test pass so we can work on thumbor-community/aws#147

This base image only (roughly) contains up to date dependencies needed to run test for tc_aws on CircleCI (and locally).

@Bladrak If the CircleCI + Docker Hub setup is still working we should be able to use this together with: thumbor-community/aws#153

@Bladrak
Copy link
Owner

Bladrak commented Feb 9, 2022

Aren't we missing opencv from this image? Did the tests pass with it?

@peterrus
Copy link
Contributor Author

peterrus commented Feb 9, 2022

@Bladrak I saw no indication that this docker image was used in Thumbor itself (anymore): https://github.com/thumbor/thumbor/blob/master/.circleci/config.yml#L14

So basically this image is only used for tc_aws as far as I know. So the tc_aws tests did indeed pass when running this image locally (and I suspect it will also pass on CircleCI).

@Bladrak
Copy link
Owner

Bladrak commented Feb 9, 2022

Ok let's try it then :)

@Bladrak Bladrak merged commit a58c1ec into Bladrak:master Feb 9, 2022
@peterrus peterrus deleted the fix_circleci_python3 branch February 9, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants