Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme with how to include oq into docker image #44

Merged
merged 1 commit into from
Dec 29, 2019
Merged

Update readme with how to include oq into docker image #44

merged 1 commit into from
Dec 29, 2019

Conversation

Blacksmoke16
Copy link
Owner

@Blacksmoke16 Blacksmoke16 commented Dec 28, 2019 •
edited
Loading

Resolves #39.

Since the binary on Github is statically linked, they can pretty easily be included into a Docker image. There isn't really a point in having a standalone oq image since at that point all it would be doing is installing jq and wrapping a binary.

@Blacksmoke16 Blacksmoke16 mentioned this pull request Dec 29, 2019
Closed
@Blacksmoke16 Blacksmoke16 merged commit dadc25d into master Dec 29, 2019
@Blacksmoke16 Blacksmoke16 deleted the docker-instructionss branch December 29, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oq does not work in a docker container
1 participant
@Blacksmoke16