-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xml deserialization #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep track of bugs I find while trying out this:
|
Cleanup some error handling code
Add some more comments so i remember how this works
Add specs for invalid IO format Simplify invalid IO format logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial implementation of XML deserialization. I added tests for a good amount of cases, however I think it would be best to get something out there and fix stuff as it appears verus delaying this forever until I find every case.
I'm sure I'll refactor this to be better at some point. Possibly would be able to useXML::Reader
most of the time and only expand the node to determine if it has children, vs this implementation of using reader, expanding it, then using the expanded Node the rest of the time.See: #37 (comment)
Resolves #31.
will probably wait for a better implementation before working on #7.@nichtich I'd appreciate if you want to give this a try to see if you can find anything I missed.