Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml deserialization #37

Merged
merged 16 commits into from
Oct 27, 2019
Merged

Xml deserialization #37

merged 16 commits into from
Oct 27, 2019

Conversation

Blacksmoke16
Copy link
Owner

@Blacksmoke16 Blacksmoke16 commented Oct 9, 2019

Add initial implementation of XML deserialization. I added tests for a good amount of cases, however I think it would be best to get something out there and fix stuff as it appears verus delaying this forever until I find every case.

I'm sure I'll refactor this to be better at some point. Possibly would be able to use XML::Reader most of the time and only expand the node to determine if it has children, vs this implementation of using reader, expanding it, then using the expanded Node the rest of the time.

See: #37 (comment)

Resolves #31. will probably wait for a better implementation before working on #7. @nichtich I'd appreciate if you want to give this a try to see if you can find anything I missed.

@Blacksmoke16
Copy link
Owner Author

Blacksmoke16 commented Oct 14, 2019

To keep track of bugs I find while trying out this:

  • - Support CDATA

@Blacksmoke16
Copy link
Owner Author

Blacksmoke16 commented Oct 21, 2019

UPDATE:

I've refactored the deserialization logic in 652764d. It's now in a spot I'm much more comfortable with. Will give it a few days if anyone wants to look over it and see if I missed anything. Otherwise should be good to go?

\cc @nichtich @Nowaker

Add specs for invalid IO format
Simplify invalid IO format logic
@Blacksmoke16 Blacksmoke16 merged commit 960e10e into master Oct 27, 2019
@Blacksmoke16 Blacksmoke16 deleted the xml-deserialization branch October 27, 2019 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support XML as input format
1 participant