Fix StringIndexOutOfBoundsException #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some locales (e.g. Chinese), the method getShortWeekdays() in ateFormatSymbols used in the CaldarView class will return an array of string which are only two characters long. In this case, String.substring() method in the loop, which was hardcoded with parameter (0, 3) will throw a StringIndexOutOfBoundsException since there is only two characters in the returned string. This commit fixes this behavior by first determining the length of the string, then use either the length of the string or 3 as the second parameter to the substring() method.
|
Fixes issue #1 |
JonatanSalas
pushed a commit
that referenced
this pull request
Nov 6, 2015
Fix StringIndexOutOfBoundsException
|
Thanks for your help! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some locales (e.g. Chinese), the method
getShortWeekdays()inDateFormatSymbolsused in theCalendarViewclass will return an arrayof string which are only two characters long.
In this case,
String.substring()method in the loop, which washardcoded with parameter
(0, 3)will throw aStringIndexOutOfBoundsExceptionsince there is only two characters in the returned string.
This commit fixes this behavior by first determining the length of the
string, then use either the length of the string or 3 as the second
parameter to the
substring()method.