Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct version regex in semantic release config for version updates #37

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

Bjarten
Copy link
Owner

@Bjarten Bjarten commented Nov 11, 2024

Overview

This PR fixes an issue with python-semantic-release where the version in __init__.py was not updated during releases due to an incorrect version_variable configuration in pyproject.toml.

Changes Made

  1. Updated version_variable in pyproject.toml:
    • Changed the version_variable setting to use an explicit regex pattern: early_stopping_pytorch/__init__.py:^__version__ = "(.*)".
    • This pattern directly matches the format of the version string in __init__.py, allowing python-semantic-release to locate and update it successfully.

@Bjarten Bjarten merged commit a3a82b2 into main Nov 11, 2024
5 checks passed
@Bjarten Bjarten deleted the fix/versioning-tag branch November 11, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant