Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: semantic release version updating pattern #36

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

Bjarten
Copy link
Owner

@Bjarten Bjarten commented Nov 11, 2024

Description

This PR fixes the version updating in __init__.py by making the version pattern more explicit in semantic-release configuration.

Issue

While pyproject.toml version is being updated correctly during release, the version in __init__.py remains unchanged. This is due to semantic-release needing a more explicit pattern to find and replace the version string.

Changes

Updated in pyproject.toml:

[tool.semantic_release]
# Old
# version_variable = ["early_stopping_pytorch/__init__.py:__version__"]

# New - explicit pattern
version_variable = ["early_stopping_pytorch/__init__.py:__version__ = \"{version}\""]

@Bjarten Bjarten merged commit ccda0f5 into main Nov 11, 2024
5 checks passed
@Bjarten Bjarten deleted the fix/versioning branch November 11, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant