Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Run build in post install hook #2

Closed
2 tasks done
mejiaj opened this issue Feb 9, 2024 · 1 comment
Closed
2 tasks done

Dependencies: Run build in post install hook #2

mejiaj opened this issue Feb 9, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Feb 9, 2024

Starter theme has instructions to run NPM commands

nvm use
npm install
npm run build

Adding a postinstall hook to package.json would save us a step.

"scripts": {
"test": "echo \"Error: no test specified\" && exit 1",
"build": "npx gulp"
},

Calling npm run build here will always run it after install.

Tasks

  • Create postinstall script
  • Update starter_theme README
@mejiaj mejiaj added documentation Improvements or additions to documentation good first issue Good for newcomers labels Feb 9, 2024
@rayestrada
Copy link
Contributor

This issue is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants