fixes #110 : [V2] Cohort Application Page #117
Conversation
| <input type="submit" value="Submit" /> | ||
| </form> | ||
| </section> | ||
| </> |
There was a problem hiding this comment.
This. SInce there is only one child section we dont need <></>
There was a problem hiding this comment.
My mistake. this is needed now
Pls add styling for background and submit button |
|
|
package.json
Outdated
| "react": "^18.0.0", | ||
| "react-dom": "^18.0.0", | ||
| "react-icons": "^4.12.0", | ||
| "react-select": "^5.8.0", |
There was a problem hiding this comment.
we already have material-ui so can we use those components? https://mui.com/material-ui/react-select?
| import Select from 'react-select'; | ||
|
|
||
| const Application = ( | ||
| {name}: {name: string} |
There was a problem hiding this comment.
we might need one more prop isRegOpen. We will not be accepting applications for all cohorts simultaneously
There was a problem hiding this comment.
can we change to cohortName, as name is misleading
| required | ||
| /> | ||
| <p>Location*</p> | ||
| <input |
There was a problem hiding this comment.
The inputs can be made into a single component and looped over
There was a problem hiding this comment.
Also check if material-ui has input component, it will look prettier
| import Select from 'react-select'; | ||
|
|
||
| const Application = ( | ||
| {name}: {name: string} |
There was a problem hiding this comment.
can we change to cohortName, as name is misleading
| const [selectedSkills, setSelectedSkills] = useState([]); | ||
| const [selectedBooks, setSelectedBooks] = useState([]); |
There was a problem hiding this comment.
We can use formData.Skills and formData.books?
| formData.skills = selectedSkills; | ||
| formData.books = selectedBooks; |
There was a problem hiding this comment.
We can set this in handleChange itself
| @@ -0,0 +1,194 @@ | |||
| import React, { useState, type FormEvent } from "react"; | |||
| import axios from "axios"; | |||
| import { Alert, Autocomplete, Input, TextField } from "@mui/material"; | |||
| <input type="submit" value="Submit" /> | ||
| </form> | ||
| </section> | ||
| </> |
There was a problem hiding this comment.
This. SInce there is only one child section we dont need <></>
| ]; | ||
|
|
||
| const Application = ( | ||
| { cohortName }: { cohortName: string } |
There was a problem hiding this comment.
can we add a boolean isRegOpen so that we open applications only for some cohorts?
There was a problem hiding this comment.
Also pls check with @rajarshimaitra which cohort applications should be open when we merge this PR
| enrolled: false, | ||
| role: cohortName | ||
| }); | ||
| const [isRegOpen, setIsRegOpen] = useState(regOpen); |
There was a problem hiding this comment.
We dont need this state. We can directly use regOpen
| onChange={(e, value) => { | ||
| setFormData(prevState => ({ | ||
| ...prevState, | ||
| skills: value |
There was a problem hiding this comment.
Type of value is string[]. This doesnt match the type of skills. Can you fix the type issue?
| onChange={(e, value) => { | ||
| setFormData(prevState => ({ | ||
| ...prevState, | ||
| books: value |
There was a problem hiding this comment.
Type issue just as skills
| <input type="submit" value="Submit" /> | ||
| </form> | ||
| </section> | ||
| </> |
There was a problem hiding this comment.
My mistake. this is needed now
|
Also we need to add some validations so that user enters all the fields as right now we allow submission of empty fields |
We will start with the BPD cohort. |
|
Fixed the type issues, and also changed the order of the questions. here is the new order. @setusaurabh does this look alright to you? also added validation for the required fields. |
|
@emjshrx lets hold on to this until we finalize the date for BPD. Then we can merge this with only the BPD application open and everything else closed. |
Created a basic ui for applying to the cohorts. we can change the design based on the revamped design