Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct hash prefixes used in tests and use consistent pubkey, add tests to reject bitcoin addresses #57

Closed
wants to merge 18 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3c0c6c4
correct python3 comparison operator
slowriot Aug 19, 2021
e027dc7
enable building tests by default, external signer default to match bi…
slowriot Aug 20, 2021
0f69252
reinstate valid base58 test data and test methodology from bitcoin core
slowriot Aug 20, 2021
60bc8a1
fix base58 implementation
slowriot Aug 20, 2021
a0305ee
do not enable DEBUG_LOCKORDER for all debug builds; the code associat…
slowriot Aug 24, 2021
9781fd3
don't disable implicit-fallthrough warning (this is now dealt with in…
slowriot Aug 24, 2021
2f0b88f
enable building tests by default
slowriot Aug 25, 2021
4bf285e
re-enable asserts for signet chain params at creation, with correct g…
slowriot Aug 25, 2021
9225ec0
remove unused include
slowriot Aug 25, 2021
95a1703
add tests to verify test addresses are valid - this also tests the va…
slowriot Aug 25, 2021
5555e69
fix failing key_tests, set correct prefix (10) for addresses - the pr…
slowriot Aug 25, 2021
4d72a07
add a test to ensure a BTC address does not count as a valid destination
slowriot Aug 25, 2021
43306dc
Merge branch 'base58_fixes' into genesis_hashes
slowriot Aug 25, 2021
f4a744d
update benchmark decode address to BGL prefix for consistency
slowriot Aug 25, 2021
2f87ecb
update test data sample BTC address to BGL format with prefix 10
slowriot Aug 25, 2021
28ed84b
test data - update BTC format addresses to their BGL equivalent with …
slowriot Aug 25, 2021
4024b28
some tests use the pubkey of the BTC genesis block - update these to …
slowriot Aug 25, 2021
265f53a
update values used in util_tests fixes to match janus branch, to reso…
slowriot Sep 1, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused include
slowriot committed Aug 25, 2021
commit 9225ec0ed400d824b21e9b633ab2dddb5643b310
1 change: 0 additions & 1 deletion src/test/key_tests.cpp
Original file line number Diff line number Diff line change
@@ -9,7 +9,6 @@
#include <test/util/setup_common.h>
#include <uint256.h>
#include <util/strencodings.h>
#include <util/string.h>
#include <util/system.h>

#include <string>