Port multiple master-targeted fixes to janus release branch#56

Closed

slowriot wants to merge 32 commits intoBitgesellOfficial:janus/release-0.1.7from slowriot:janus_fixes1

+429-410

Commits on Sep 1, 2021

correct python3 comparison operator
slowriot
committed
enable building tests by default, external signer default to match bitcoin core, and turn off warning silencing for implicit fallthrough
slowriot
committed
reinstate valid base58 test data and test methodology from bitcoin core
slowriot
committed
declare classes final where appropriate, to enable devirtualisation of calls, and add placeholder warning to suggest possible final types
slowriot
committed
add warning to suggest attribute noreturn if applicable
slowriot
committed
add warning to suggest attribute const and placeholder warning for attribute pure
slowriot
committed
add single warning for "unused" warning options
slowriot
committed
add attribute [[maybe_unused]] to mark parameters that are known not to be used, and re-enable unused parameter warning to identify unintentionally unused parameters in future
slowriot
committed
remove unused debugging includes
slowriot
committed
use C++17 fallthrough attributes instead of comments, resolve fallthrough warning
slowriot
committed
add modern fallthrough attribute, replace old hacky solutions
slowriot
committed
tidy and remove unneeded braces for cases that don't require them
slowriot
committed
add warning for non-virtual destructor in base class, and fix all instances
slowriot
committed
add extra performance and safety compiler warnings
slowriot
committed
add warning for implicit double promotion
slowriot
committed
avoid unnecessary double promotion in calculating time interval, and replace C cast with static_cast
slowriot
committed
avoid implicit conversions that may alter a value, or make them explicit where intended
slowriot
committed
placeholder warnings for conversion and useless casts
slowriot
committed
do not enable DEBUG_LOCKORDER for all debug builds; the code associated with this flag is broken in any case
slowriot
committed
remove unused includes
slowriot
committed
don't disable implicit-fallthrough warning (this is now dealt with in another PR)
slowriot
committed
re-enable asserts for signet chain params at creation, with correct genesis block hash and merkle root hash
slowriot
committed
remove unused include
slowriot
committed
add tests to verify test addresses are valid - this also tests the validator
slowriot
committed
add a test to ensure a BTC address does not count as a valid destination
slowriot
committed
enable building tests by default, external signer default to match bitcoin core, and turn off warning silencing for implicit fallthrough
slowriot
committed
don't disable implicit-fallthrough warning (this is now dealt with in another PR)
slowriot
committed
update benchmark decode address to BGL prefix for consistency
slowriot
committed
update test data sample BTC address to BGL format with prefix 10
slowriot
committed
some tests use the pubkey of the BTC genesis block - update these to use the correct pubkey of the BGL genesis block instead
slowriot
committed
Revert "don't disable implicit-fallthrough warning (this is now dealt with in another PR)"
slowriot
committed
remove attribute final from classes Sock, CCoinsViewCache, DescriptorScriptPubKeyMan to accomodate new fuzzing classes
slowriot
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port multiple master-targeted fixes to janus release branch#56

Commits on Sep 1, 2021

correct python3 comparison operator

enable building tests by default, external signer default to match bitcoin core, and turn off warning silencing for implicit fallthrough

reinstate valid base58 test data and test methodology from bitcoin core

declare classes final where appropriate, to enable devirtualisation of calls, and add placeholder warning to suggest possible final types

add warning to suggest attribute noreturn if applicable

add warning to suggest attribute const and placeholder warning for attribute pure

add single warning for "unused" warning options

add attribute [[maybe_unused]] to mark parameters that are known not to be used, and re-enable unused parameter warning to identify unintentionally unused parameters in future

remove unused debugging includes

use C++17 fallthrough attributes instead of comments, resolve fallthrough warning

add modern fallthrough attribute, replace old hacky solutions

tidy and remove unneeded braces for cases that don't require them

add warning for non-virtual destructor in base class, and fix all instances

add extra performance and safety compiler warnings

add warning for implicit double promotion

avoid unnecessary double promotion in calculating time interval, and replace C cast with static_cast

avoid implicit conversions that may alter a value, or make them explicit where intended

placeholder warnings for conversion and useless casts

do not enable DEBUG_LOCKORDER for all debug builds; the code associated with this flag is broken in any case

remove unused includes

don't disable implicit-fallthrough warning (this is now dealt with in another PR)

re-enable asserts for signet chain params at creation, with correct genesis block hash and merkle root hash

remove unused include

add tests to verify test addresses are valid - this also tests the validator

add a test to ensure a BTC address does not count as a valid destination

enable building tests by default, external signer default to match bitcoin core, and turn off warning silencing for implicit fallthrough

don't disable implicit-fallthrough warning (this is now dealt with in another PR)

update benchmark decode address to BGL prefix for consistency

update test data sample BTC address to BGL format with prefix 10

some tests use the pubkey of the BTC genesis block - update these to use the correct pubkey of the BGL genesis block instead

Revert "don't disable implicit-fallthrough warning (this is now dealt with in another PR)"

remove attribute final from classes Sock, CCoinsViewCache, DescriptorScriptPubKeyMan to accomodate new fuzzing classes