Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate tx_valid.json file with valid transactions data #13

Open
van-orton opened this issue Oct 13, 2020 · 17 comments
Open

Generate tx_valid.json file with valid transactions data #13

van-orton opened this issue Oct 13, 2020 · 17 comments

Comments

@van-orton
Copy link
Collaborator

Description

src/test/data/tx_valid.json contains data for various transactions that are simulated during the unit test execution.
Because of the different hashing algorithm used (keccak instead of double sha256) in BGL, this file has to be regenerated
for tests section to pass.
The test section is commented out and located in src/test/transaction_tests.cpp

Solution direction

The only differences should be only hashing algorithm used for txs (keccak) and that transactions are required to be segwit ('new' type).

  • Uncomment test section in transaction_tests.cpp;
  • Build and run unit test executable and see the section failing;
  • Create a simple transaction data that will pass the test (there are keccak3 utils/online tools, etc.)
  • Fix transaction data that can be fixed, include new testing data if removed some to keep test robust enough;

Acceptance criteria

  • transaction_tests.cpp is running BOOST_AUTO_TEST_CASE(tx_valid) properly;
  • there are numerous test cases defined in the json file (maybe fewer than in original one, but not by order of magnitude);
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 1.0432 ETH (400.51 USD @ $383.93/ETH) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 266 years, 1 month from now.
Please review their action plans below:

1) hhio618 has been approved to start work.

I'll fix the data for this test case and make sure BOOST_AUTO_TEST_CASE(tx_valid) runs properly.
2) atiwat31 has applied to start work (Funders only: approve worker | reject worker).

ไว้เพื่อหาข้อมูลศึกษาค้นคว่า และนำไปลงทุนความเสื่ยงในเกม
3) efrainleuck has applied to start work (Funders only: approve worker | reject worker).

I will generate numerous test cases in the defined Tx_valid.json file and ensure transaction_test.cpp is running BOOST_AUTO_TEST_CASE(tx_valid)properly.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

@hhio618 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

2 similar comments
@gitcoinbot
Copy link

@hhio618 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@hhio618 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@hhio618
Copy link

hhio618 commented Oct 19, 2020

Hi, I've been a little busy. I'll submit a pr ASAP.

@gitcoinbot
Copy link

@hhio618 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

gitcoinbot commented Oct 25, 2020 •
edited by wu-emma
Loading

@hhio618 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@wu-emma
Copy link
Collaborator

wu-emma commented Oct 26, 2020

@hhio618 Hi, how're you doing? Can we expect the PR to be created soon? Please make an update.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@hhio618 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@hhio618
Copy link

hhio618 commented Oct 26, 2020

@wu-emma I apologize and really sorry for being too late. It’s been a rough two week for me and my family duo infection with covid-19, so that’s the reason for me to progress very slowly within these two weeks. In exchange for that I’m willing to this even without any payment if you still want me to do it?

@gitcoinbot
Copy link

@hhio618 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@hhio618 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@hhio618 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@hhio618 due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

wu-emma pushed a commit that referenced this issue Jul 19, 2021
@van-orton
Returned Keccak hashing and burn BGL changes (#13)
7af3521 
* Returned Keccak hashing and burn BGL changes

* Remove duplicate lines

* Fix interfaces refactoring

Co-authored-by: VanOrton <>
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 1.0432 ETH (1259.69 USD @ $1211.24/ETH) attached to this issue has been cancelled by the bounty submitter

@gitcoinbot
Copy link

gitcoinbot commented Jun 26, 2022 •
edited
Loading

Issue Status: 1. Open 2. Cancelled

Work has been started.

These users each claimed they can complete the work by 264 years, 4 months from now.
Please review their action plans below:

1) hhio618 has been approved to start work.

I'll fix the data for this test case and make sure BOOST_AUTO_TEST_CASE(tx_valid) runs properly.

Learn more on the Gitcoin Issue Details page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hhio618 @gitcoinbot @wu-emma @van-orton