Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for non-Python projects #65

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

evamillan
Copy link
Contributor

This PR adds the --current-version arg to the semverup command and the --add-all flag to publish to avoid needing to use Python package specific files like _version.py or pyproject.toml.

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ccf6754) 95.53% compared to head (a5156f0) 95.34%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   95.53%   95.34%   -0.19%     
==========================================
  Files           8        8              
  Lines         716      730      +14     
==========================================
+ Hits          684      696      +12     
- Misses         32       34       +2     
Files Coverage Δ
release_tools/publish.py 95.32% <100.00%> (+0.13%) ⬆️
release_tools/semverup.py 95.48% <100.00%> (+0.24%) ⬆️
release_tools/repo.py 68.96% <33.33%> (-1.95%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -0,0 +1,12 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this as two features. Why don't you split it in two changelog files? I would also do the same with the commits.

release_tools/publish.py Show resolved Hide resolved
Adds the '--current-version' argument to 'semverup'.
This uses the given version number instead of looking
for it on '_version.py'.

Signed-off-by: Eva Millán <[email protected]>
Adds the '--add-all' option to the 'publish' command
to include all changed files in the release commit.

Signed-off-by: Eva Millán <[email protected]>
@evamillan evamillan force-pushed the non-python-projects branch from 66932e8 to a5156f0 Compare October 10, 2023 14:39
@evamillan
Copy link
Contributor Author

@sduenas I updated the PR with the changes you requested.

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduenas sduenas merged commit efb7591 into Bitergia:master Oct 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants