New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[panels] update attribute-template.json #207

Merged

valeriocos merged 1 commit into Bitergia:master from vchrombie:fix-204

Mar 31, 2020

Contributor

vchrombie commented Mar 30, 2020

This PR updates the panels template for creating a dashboard during visualization.

Fixes #204

Contributor Author

vchrombie commented Mar 30, 2020 •

edited

Loading

Hi @valeriocos
I completed the work as stated in the #204. I exported the updated dashboard using Kidash. I tested the change by deleting the dashboard and running the visualization again. Next time, the dashboard was generated without any trouble.

I have a few doubts though. Please review this PR when you have time.

vchrombie commented

View reviewed changes

django-prosoul/prosoul/panels/templates/attribute-template.json Outdated Show resolved Hide resolved

vchrombie commented

View reviewed changes

django-prosoul/prosoul/panels/templates/attribute-template.json Show resolved Hide resolved

vchrombie commented

View reviewed changes

django-prosoul/prosoul/panels/templates/attribute-template.json Outdated Show resolved Hide resolved

vchrombie commented

View reviewed changes

django-prosoul/prosoul/panels/templates/attribute-template.json Show resolved Hide resolved

vchrombie commented

View reviewed changes

django-prosoul/prosoul/panels/templates/attribute-template.json Outdated Show resolved Hide resolved

vchrombie force-pushed the fix-204 branch from 1a9e726 to b61c83f Compare

March 31, 2020 09:09


          [panels] update attribute-template.json

038ca23

This commit updates the panels template for
creating a dashboard during visualization.

Signed-off-by: Venu Vardhan Reddy Tekula <[email protected]>

vchrombie force-pushed the fix-204 branch from b61c83f to 038ca23 Compare

March 31, 2020 13:24

Contributor Author

vchrombie commented Mar 31, 2020

Done! 🎉

valeriocos self-requested a review

March 31, 2020 13:49

valeriocos approved these changes

View reviewed changes

Contributor

valeriocos left a comment

LGTM, thank you @vchrombie !

valeriocos merged commit c01766d into Bitergia:master

vchrombie deleted the fix-204 branch

April 8, 2020 14:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet