LSPS0: underscores in method names #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
100% |
ZmnSCPxj-jr
suggested changes
Aug 14, 2023
Use underscores in method names in LSPS0, for consistency throughout the spec.
JssDWt
force-pushed
the
underscored_methods
branch
from
cb872ec to
ebc8ab5
Compare
|
Added:
|
ZmnSCPxj-jr
approved these changes
Aug 14, 2023
tnull
approved these changes
Aug 15, 2023
|
This seems an uncontroversial change, OK with merging even outside of LSPS meeting. |
ErikDeSmedt
added a commit
to ErikDeSmedt/greenlight
that referenced
this pull request
Aug 17, 2023
cdecker
pushed a commit
to ErikDeSmedt/greenlight
that referenced
this pull request
Aug 21, 2023
cdecker
pushed a commit
to Blockstream/greenlight
that referenced
this pull request
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use underscores in method names in LSPS0, for consistency throughout the spec.
Main edit: Changes
lsps0.listprotocolstolsps0.list_protocols