Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] fit_bootstrap appends empty list #1

Closed
ulupo opened this issue May 14, 2024 · 0 comments · Fixed by #2
Closed

[BUG] fit_bootstrap appends empty list #1

ulupo opened this issue May 14, 2024 · 0 comments · Fixed by #2
Assignees
@ulupo
Labels
bug Something isn't working
Milestone
0.1.1

Comments

@ulupo
Copy link
Collaborator

ulupo commented May 14, 2024

Empty lists are appended to the fields of a DiffPaSSResults object by DiffPaSSModel.fit_bootstrap if can_optimize is True at the end of a bootstrap.
@ulupo ulupo self-assigned this May 14, 2024
@ulupo ulupo added the bug Something isn't working label May 14, 2024
@ulupo ulupo added this to the 0.1.1 milestone May 14, 2024
ulupo added a commit to ulupo/DiffPaSS that referenced this issue May 14, 2024
@ulupo
Fix Bitbol-Lab#1
a95cf90 
- Multiply by a boolean to add nothing instead of an empty slice
- Use dataclass.replace to properly replace fields in reshape step
@ulupo ulupo closed this as completed in dcab707 May 14, 2024
@ulupo ulupo mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulupo ulupo

Labels
bug Something isn't working
Projects
None yet
Milestone
0.1.1
Development

Successfully merging a pull request may close this issue.

[BUG] Fix fit_bootstrap appending empty lists ulupo/DiffPaSS
1 participant
@ulupo