Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding non-bitgo recovery support for coredao and oas #519

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

parasgarg-bitgo
Copy link
Contributor

Ticket: WIN-4290

case 'opeth':
case 'topeth':
case 'polygon':
case 'tpolygon':
case 'bsc':
case 'tbsc':
console.log('Entered toas case');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This console statement can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. Thanks for the catch

@mohitkh7
Copy link
Contributor

mohitkh7 commented Jan 24, 2025

@parasgarg-bitgo are we missing a switch case in BuildUnsignedSweepCoin.tsx?

@parasgarg-bitgo
Copy link
Contributor Author

@parasgarg-bitgo are we missing a switch case in BuildUnsignedSweepCoin.tsx?

We'll add support for unsigned sweep in a separate PR.

Copy link
Contributor

@mohitkh7 mohitkh7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@parasgarg-bitgo parasgarg-bitgo merged commit 9d9ff95 into master Feb 10, 2025
5 checks passed
@parasgarg-bitgo parasgarg-bitgo deleted the WIN-4290 branch February 10, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants