prost: Pre-compile the tool #829
Conversation
| @@ -56,8 +58,7 @@ add_custom_command( | |||
| # Using prost-build the normal way as part of build.rs does not work due to a cargo bug: | |||
| # https://github.com/danburkert/prost/issues/344#issuecomment-650721245 | |||
There was a problem hiding this comment.
Repo moved, the comment is now here: tokio-rs/prost#344 (comment)
It seems the relevant bug has been fixed and stabilized in 1.51.
I think this means we can delete the prost-build altogether and use prost as it is documented, without using this custom tool as a workaround.
There was a problem hiding this comment.
Yeah, I made a new PR.
|
Let's go with this one, seems to have many benefits over the other (faster build times, no explosion in the vendor folder, etc). I build and pushed the Dockerfile with the changes of this PR as tag 22. If you rebase and point CI to https://github.com/digitalbitbox/bitbox02-firmware/pull/839/files (or wait until that PR is merged and then rebase). |
There was a problem hiding this comment.
tACK, but best to wait until https://github.com/digitalbitbox/bitbox02-firmware/pull/839/files is merged and then rebase, so the CI here can pass.
NickeZ
force-pushed
the
pre-compile-prost-build
branch
from
0b88f3c to
5aa240e
Compare
|
rebased |
Compiling the tool at build time increases build time and complicates things when we want to support "cargo test" in the rust libraries.
NickeZ
force-pushed
the
pre-compile-prost-build
branch
from
5aa240e to
03fa841
Compare
Compiling the tool at build time increases build time and complicates
things when we want to support "cargo test" in the rust libraries.