frontend: set width for dropdowns in settings page #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonsirsha
commented
Feb 4, 2025
| .select :global(.react-select__option) { | ||
| padding: var(--space-half) var(--space-quarter); | ||
| } | ||
|
|
||
|
|
||
| @media (max-width: 768px) { | ||
| .select { | ||
| margin-top: var(--space-quarter); | ||
| margin-top: 12px; |
There was a problem hiding this comment.
Increased the margin slightly on mobile (when collapsed / flex-col). Not related to width but since we're here anyway. :)
currently, the width of these dropdowns in the settings page follow the content inside it, causing it to look inconsistent. We unify their width to improve the UI.
shonsirsha
force-pushed
the
frontend-fix-width-settings-dropdowns
branch
from
9ef0a3a to
72b378f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the width of these dropdowns in the settings page
follow the content inside it, causing it to look inconsistent.
We unify their width to improve the UI.
Before:
After:
