frontend: change support links to redirects #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisconnect
requested changes
Apr 26, 2024
|
finally test-lint failed again, seems to happen related to nodejs 20 and should be fixed with #2686 |
|
LGTM but maybe squash both commits? |
Replacing external links to our knowledge base with redirects on the website enables easy and swift updates for everyone if the knowledge base URL ever changes in the future, e.g. because of a domain change. This will avoid broken links in old BitBoxApp versions. The new redirect links are already implemented on the website.
sutterseba
force-pushed
the
replace-support-links
branch
from
946b379
to
e3d401b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing external links to our knowledge base with redirects on the website enables easy and swift maintenance if the knowledge base URL ever changes in the future, e.g. because of a domain change or entirely new knowledge base system.
This will avoid broken links in old BitBoxApp versions in the future. The new redirect links are already implemented on the website.