Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: log rendering mode #2599

Merged
merged 1 commit into from
Mar 4, 2024
Merged

qt: log rendering mode #2599

merged 1 commit into from
Mar 4, 2024

Conversation

benma
Copy link
Contributor

@benma benma commented Feb 29, 2024

If a user manually has to set this, it would be helpul to see this msg
to know that the right var was set.

@benma benma requested review from Beerosagos and removed request for Beerosagos February 29, 2024 15:06
@benma benma changed the title qt: log to stderr if automatic rendering was chosen qt: log rendering mode Feb 29, 2024
@benma benma requested a review from Beerosagos February 29, 2024 15:25
If a user manually has to set this, it would be helpul to see this msg
to know that the right var was set.
Copy link
Collaborator

@Beerosagos Beerosagos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK!

Maybe it could be useful to log the value in case it is invalid. wdyt?

@benma
Copy link
Contributor Author

benma commented Mar 4, 2024

I thought about it but it's C++, was too annoying to assemble the string 😅

I want to make this a command line argument anyway, as setting the env var is horrible from a UX point of view (CLI flag is also not great, but a lot better)

@benma benma merged commit b829880 into BitBoxSwiss:master Mar 4, 2024
5 checks passed
@benma benma deleted the renderlog branch March 4, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants