frontend: handle zero amount invoices when sending with lightning #2571
Conversation
thisconnect
force-pushed
the
frontend-ln-handle-zeroamount
branch
from
007d584 to
5d15765
Compare
|
I sometimes got this error, but at least once it went through
in phoenix: "1 incoming payment recently rejected" reason: "The fee was 2976 sat which is more than 50% of the amount" I have 600k inbound liquidity |
You normally set the description / memo when creating the invoice (receiver side), not when paying the invoice |
thisconnect
force-pushed
the
frontend-ln-handle-zeroamount
branch
from
5d15765 to
b38b9cf
Compare
Thanks, I expected that it's not possible. I removed the TODO and updated the commit message, thanks @dangeross |
|
@Beerosagos PTAL |
| value={customAmount ? `${customAmount}` : ''} | ||
| autoFocus | ||
| /> | ||
| <Input |
There was a problem hiding this comment.
This input should be removed, I think
There was a problem hiding this comment.
I kept as readonly input so that the user can read the memo/description
| await postSendPayment({ | ||
| bolt11: paymentDetails.invoice.bolt11, | ||
| // amountMsat is optional, if amount is missing the UI shows edit-invoice step for the user to enter a custom amountMsat which is passed here | ||
| amountMsat: customAmount |
There was a problem hiding this comment.
AFAIK amountMsat unit is milli satoshi. The amount should be multiplied * 1000
From my tests, the reason of this error is the missing conversion to milli sats: Setting 1000 in the input seems to successfully send a 1sat transaction |
thisconnect
force-pushed
the
frontend-ln-handle-zeroamount
branch
from
b38b9cf to
5bfc632
Compare
|
rebased |
thisconnect
force-pushed
the
frontend-ln-handle-zeroamount
branch
2 times, most recently
from
2cc56c1 to
8b2f595
Compare
|
@Beerosagos PTAL |
Added a new step edit-invoice to allow specifying a custom amount if no amount was given or amount is 0. Other change: - back button on confirm screen goes now back to the lighting view was going back to the QR scanner - changed Sats to Sat so it is consitent with the rest of the app
thisconnect
force-pushed
the
frontend-ln-handle-zeroamount
branch
from
8b2f595 to
e7a8224
Compare
Added a new step edit-invoice to allow specifying a custom amount if no amount was given or amount is 0.
Other change: