frontend: refactor, fixes bugs, add test cases for formatNumber
#2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe @Beerosagos wrote the initial version, so I just defer to him... |
thisconnect
requested review from
Beerosagos
and removed request for
thisconnect
there was previously a bug where it formats negative 3 digits negative number (e.g -100) to become -'100. This PR fixes this as well as adding tests and moved the function to `utils/rates.ts`
Beerosagos
approved these changes
Feb 21, 2024
shonsirsha
force-pushed
the
frontend-format-number-fn-refactor
branch
from
071474d to
6a7b89f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was previously a bug where it formats negative 3 digits negative number (e.g -100) to become -'100. This PR fixes this as well as adding tests and moved the function to
utils/rates.ts