(#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ELD_NAME instead Signed-off-by: acarbonetto <[email protected]>
…ELD_NAME instead Signed-off-by: acarbonetto <[email protected]>
acarbonetto
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey and
GumpacG
as code owners
…reservedSymbolTable-1506 Signed-off-by: acarbonetto <[email protected]>
acarbonetto
changed the title
Codecov Report
@@ Coverage Diff @@
## integ-remove-reservedSymbolTable-1506 #323 +/- ##
===========================================================================
- Coverage 97.42% 97.42% -0.01%
+ Complexity 4647 4646 -1
===========================================================================
Files 408 408
Lines 11526 11524 -2
Branches 839 839
===========================================================================
- Hits 11229 11227 -2
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: acarbonetto <[email protected]>
GumpacG
approved these changes
Aug 4, 2023
MitchellGale
approved these changes
Aug 4, 2023
matthewryanwells
approved these changes
Aug 4, 2023
Yury-Fridlyand
approved these changes
Aug 4, 2023
acarbonetto
added a commit
that referenced
this pull request
Aug 4, 2023
… HIDDEN_FIELD_NAME (#323) * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1506: Fix checkstyle errors Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]>
acarbonetto
added a commit
that referenced
this pull request
Aug 15, 2023
… HIDDEN_FIELD_NAME (opensearch-project#1936) * (opensearch-project#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME (#323) * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1506: Fix checkstyle errors Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1506: spotless apply Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> (cherry picked from commit 5381a6f) Signed-off-by: acarbonetto <[email protected]>
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Aug 16, 2023
… HIDDEN_FIELD_NAME (opensearch-project#1936) * (opensearch-project#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME (#323) * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1506: Fix checkstyle errors Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]> * opensearch-project#1506: spotless apply Signed-off-by: acarbonetto <[email protected]> --------- Signed-off-by: acarbonetto <[email protected]>
MitchellGale
pushed a commit
that referenced
this pull request
Aug 21, 2023
… HIDDEN_FIELD_NAME (opensearch-project#1936) (opensearch-project#1964) * (opensearch-project#1506) Remove reservedSymbolTable and replace with HIDDEN_FIELD_NAME (#323) * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead * opensearch-project#1506: Remove reservedSymbolTable and use HIDDEN_FIELD_NAME instead * opensearch-project#1506: Fix checkstyle errors --------- * opensearch-project#1506: spotless apply --------- (cherry picked from commit 5381a6f) Signed-off-by: acarbonetto <[email protected]>
andy-k-improving
pushed a commit
that referenced
this pull request
Nov 16, 2024
Signed-off-by: Martin Gaievski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reservedSymbolTable was included to separate out fields from hidden fields. It makes more sense to use the HIDDEN_FIELD_NAME namespace instead. Nothing changes for down-stream calls.
Issues Resolved
opensearch-project#1506
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.