forked from opensearch-project/sql
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow literal in aggregation #203
Merged
Yury-Fridlyand
merged 3 commits into
integ-allow-literal-in-aggregation
from
dev-allow-literal-in-aggregation
Jan 20, 2023
Merged
Allow literal in aggregation #203
Yury-Fridlyand
merged 3 commits into
integ-allow-literal-in-aggregation
from
dev-allow-literal-in-aggregation
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query sample: ```sql select 1 from calcs GROUP BY 1; ``` Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
GumpacG,
forestmvey,
GabeFernandez310,
MaxKsyunz,
acarbonetto,
margarit-h and
matthewryanwells
January 12, 2023 19:31
Codecov Report
@@ Coverage Diff @@
## integ-allow-literal-in-aggregation #203 +/- ##
=====================================================================
Coverage ? 95.91%
Complexity ? 3610
=====================================================================
Files ? 354
Lines ? 9604
Branches ? 688
=====================================================================
Hits ? 9212
Misses ? 334
Partials ? 58
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
margarit-h
approved these changes
Jan 12, 2023
GabeFernandez310
approved these changes
Jan 18, 2023
GumpacG
approved these changes
Jan 18, 2023
forestmvey
approved these changes
Jan 20, 2023
GumpacG
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Support constant in aggregation. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]>
matthewryanwells
pushed a commit
that referenced
this pull request
Feb 1, 2023
…arch-project#1290) * Support constant in aggregation. Signed-off-by: Yury-Fridlyand <[email protected]>
andy-k-improving
pushed a commit
that referenced
this pull request
Nov 16, 2024
Fixing failure at Task ':libs:h3:validateNebulaPom' Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Fix query like
Query is pretty useless, but fix is pretty simple though.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.