Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow literal in aggregation #203

Conversation

Yury-Fridlyand
Copy link

Description

  • Minor fix for aggregation
  • Fix and reactivate some aggregation integration tests

Issues Resolved

Fix query like

select 1 from <any table> GROUP BY 1

Query is pretty useless, but fix is pretty simple though.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Query sample:
```sql
select 1 from calcs GROUP BY 1;
```

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (integ-allow-literal-in-aggregation@c6a59f7). Click here to learn what that means.
The diff coverage is n/a.

@@                          Coverage Diff                          @@
##             integ-allow-literal-in-aggregation     #203   +/-   ##
=====================================================================
  Coverage                                      ?   95.91%           
  Complexity                                    ?     3610           
=====================================================================
  Files                                         ?      354           
  Lines                                         ?     9604           
  Branches                                      ?      688           
=====================================================================
  Hits                                          ?     9212           
  Misses                                        ?      334           
  Partials                                      ?       58           
Flag Coverage Δ
query-workbench 62.76% <0.00%> (?)
sql-engine 98.35% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Yury-Fridlyand Yury-Fridlyand merged commit 7873f76 into integ-allow-literal-in-aggregation Jan 20, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the dev-allow-literal-in-aggregation branch January 20, 2023 21:26
GumpacG pushed a commit that referenced this pull request Jan 24, 2023
* Support constant in aggregation.

Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>
matthewryanwells pushed a commit that referenced this pull request Feb 1, 2023
andy-k-improving pushed a commit that referenced this pull request Nov 16, 2024
Fixing failure at Task ':libs:h3:validateNebulaPom'

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants