Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector documentation #18

Merged
8 commits merged into from
Dec 20, 2021
Merged

Connector documentation #18

8 commits merged into from
Dec 20, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 15, 2021

Description

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ghost ghost requested review from kylepbit, Yury-Fridlyand and raymond-lum December 15, 2021 23:16
Copy link

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM


<img src="img/pbi_select_connector_amz.png" width="500">

3. You will get a warning for using third-party service. Click on **Continue**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. You will get a warning for using third-party service. Click on **Continue**.
3. You will get a warning for using a third-party service. Click on **Continue**.


<img src="img/pbi_third_party_warning.png" width="500">

4. Enter server value. Click on **OK**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Enter server value. Click on **OK**.
4. Enter the server value. Click on **OK**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the server value? The hostname of the OpenSearch service?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated. This was copied from the old markdown file. I will update both files


7. Click on **Load**.

8. Select required columns for creating graph.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
8. Select required columns for creating graph.
8. Select required columns for creating a graph.


## Troubleshooting

* If you get the following error, please install [OpenSearch SQL ODBC Driver](https://docs-beta.opensearch.org/search-plugins/sql/odbc/).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* If you get the following error, please install [OpenSearch SQL ODBC Driver](https://docs-beta.opensearch.org/search-plugins/sql/odbc/).
* If you get the following error, please install the [OpenSearch SQL ODBC Driver](https://docs-beta.opensearch.org/search-plugins/sql/odbc/).


<img src="img/pbi_error_conn.png" width="350">

1. Check if host and port values are correct.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note above that you say the "server" value, but don't mention host and port.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update this. Thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the instructions above


<img src="img/pbi_connection_string_options.png" width="500">

* Select authentication option. Enter credentials if required and click on **Connect**.

<img src="img/pbi_auth.png" width="500">


Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the extra newline here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Signed-off-by: Guian Gumpac <[email protected]>
@ghost ghost merged commit 624c4ab into powerbi-main Dec 20, 2021
@GumpacG GumpacG deleted the connector-documentation branch October 18, 2022 17:33
MitchellGale added a commit that referenced this pull request Aug 17, 2023
…/4) #18 (opensearch-project#1979)

* Integration test spotless apply directory

Signed-off-by: Mitchell Gale <[email protected]>

* Address PR comments

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale added a commit that referenced this pull request Aug 22, 2023
…/4) #18 (opensearch-project#1979)

* Integration test spotless apply directory

Signed-off-by: Mitchell Gale <[email protected]>

* Address PR comments

Signed-off-by: Mitchell Gale <[email protected]>

---------

Signed-off-by: Mitchell Gale <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants