Reorganize GitHub workflows. #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove obsoleve workflows, mostly related to releaseing ODFE artifacts. * Update actions in rest workflows. * Limit workflow scopes: * Reduce file scope, for example, JDBC workflow will be triggered on JDBC changes only. * Reduce action scope, so workflows shouldn't be triggered twice on PR. Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
forestmvey,
MaxKsyunz,
acarbonetto and
MitchellGale
This comment was marked as spam.
This comment was marked as spam.
acarbonetto
requested changes
Sep 14, 2022
Signed-off-by: Yury-Fridlyand <[email protected]>
… changes. Signed-off-by: Yury-Fridlyand <[email protected]>
acarbonetto
reviewed
Sep 15, 2022
acarbonetto
approved these changes
Sep 15, 2022
Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
MitchellGale
approved these changes
Sep 15, 2022
Signed-off-by: Yury-Fridlyand <[email protected]>
MaxKsyunz
approved these changes
Sep 15, 2022
| # tests are designed to run against http://localhost:9200, so we have to disable/remove security plugin | ||
| - name: Download and run OpenSearch | ||
| run: | | ||
| wget -q https://artifacts.opensearch.org/releases/bundle/opensearch/2.2.1/opensearch-2.2.1-linux-x64.tar.gz |
There was a problem hiding this comment.
Can this use docker instead of downloading artifacts? IIRC there's a parameter there as well to turn off security.
At the very least, I'd like to see this parameterized by OpenSearch version.
There was a problem hiding this comment.
For using docker we need to store somewhere a custom docker-compose file.
I will add parametrized version, thank you.
There was a problem hiding this comment.
What does it need to customize? I thought this workflow needed an instance of opensearch to run test against.
There was a problem hiding this comment.
Oh, right, my bad! Going to fix this
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
MaxKsyunz
approved these changes
Sep 15, 2022
Signed-off-by: Yury-Fridlyand <[email protected]>
MaxKsyunz
reviewed
Sep 15, 2022
acarbonetto
approved these changes
Sep 15, 2022
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
forestmvey
reviewed
Sep 16, 2022
| @@ -9,7 +11,7 @@ on: | |||
|
|
|||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
Why did we need to switch it off of ubuntu-latest?
There was a problem hiding this comment.
To avoid any possible troubles when ubuntu-latest would be upgraded. See discussion thread there: #118 (comment).
forestmvey
reviewed
Sep 16, 2022
| with: | ||
| name: opensearch-sql | ||
| path: opensearch-sql-builds | ||
|
|
||
| - name: Upload test reports |
forestmvey
approved these changes
Sep 16, 2022
6 tasks
MitchellGale
pushed a commit
that referenced
this pull request
Oct 3, 2022
**Reorganize GitHub workflows:** * Remove obsoleve workflows, mostly related to releaseing ODFE artifacts. * Update actions in rest workflows. * Limit workflow scopes: * Reduce file scope, for example, JDBC workflow will be triggered on JDBC changes only. * Reduce action scope, so workflows shouldn't be triggered twice on PR. * Strictly define env version to avoid unexpected failures. * Upload test reports for SQL plugin workflow. * Activate tests for SQL CLI. Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yury-Fridlyand [email protected]
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.