apacheGH-30622: [GAC-11] Integrate Timestream ODBC driver into Arrow repository #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
alinaliBQ
changed the title
alinaliBQ
changed the title
|
❌ GitHub issue apache#30622 could not be retrieved. |
alinaliBQ
changed the title
alinaliBQ
force-pushed
the
alinaliBQ/GAC-11/integrate-timestream-odbc
branch
from
82a6956 to
ac950eb
Compare
* fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests
* code uploading * fix cppcheck failure (#1) * fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests * verify signer works fine * fix singer could not find the installer package * change signed installer name * fix linux package wrong name issue * restore signer flag * add .gitignore * remove unneeded files * remove unneeded files * address comments * add version to installer name * remove not needed file
…mation improvement (#4) * fix occasional test failure * document update * add check for credentials leak
* pass driver info to Timestream using user agent * add log for user agent setting
Signed-off-by: forestmvey <[email protected]>
Modified files using `clang-format` command. Hopefully this change fixes all styling issues.
alinaliBQ
force-pushed
the
alinaliBQ/GAC-11/integrate-timestream-odbc
branch
3 times, most recently
from
6c5df02 to
52849d0
Compare
alinaliBQ
force-pushed
the
alinaliBQ/GAC-11/integrate-timestream-odbc
branch
from
52849d0 to
92abd9e
Compare
|
Closing this PR for now, as we will separate integration of driver seed from lint error fixes. |
alinaliBQ
pushed a commit
that referenced
this pull request
Nov 28, 2023
* pass driver info to Timestream using user agent * add log for user agent setting
alinaliBQ
pushed a commit
that referenced
this pull request
Nov 28, 2023
* pass driver info to Timestream using user agent * add log for user agent setting
alinaliBQ
pushed a commit
that referenced
this pull request
Dec 1, 2023
* pass driver info to Timestream using user agent * add log for user agent setting
alinaliBQ
pushed a commit
that referenced
this pull request
Dec 5, 2023
* pass driver info to Timestream using user agent * add log for user agent setting
alinaliBQ
pushed a commit
that referenced
this pull request
Dec 7, 2023
* pass driver info to Timestream using user agent * add log for user agent setting
alinaliBQ
pushed a commit
that referenced
this pull request
Dec 13, 2023
* pass driver info to Timestream using user agent * add log for user agent setting
alinaliBQ
pushed a commit
that referenced
this pull request
Dec 18, 2023
* pass driver info to Timestream using user agent * add log for user agent setting
alinaliBQ
pushed a commit
that referenced
this pull request
Dec 18, 2023
* pass driver info to Timestream using user agent * add log for user agent setting
alinaliBQ
pushed a commit
that referenced
this pull request
Dec 20, 2023
…mation improvement (#4) * fix occasional test failure * document update * add check for credentials leak Fix wrong linux package name and remove unneeded files (#2) * code uploading * fix cppcheck failure (#1) * fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests * verify signer works fine * fix singer could not find the installer package * change signed installer name * fix linux package wrong name issue * restore signer flag * add .gitignore * remove unneeded files * remove unneeded files * address comments * add version to installer name * remove not needed file fix cppcheck failure (#1) * fix cppcheck failure * fix build script not running and credentials could not be fetched * restore configure-aws-credentials to v2 * add execute permission for shell scripts * remove bash for mac build scripts * trigger all tests code uploading Initial commit fix bracket missing (#5) Pass driver info to Timestream using user agent (#6) * pass driver info to Timestream using user agent * add log for user agent setting Fixing awslabs links. (#8) Signed-off-by: forestmvey <[email protected]> Move AWS TS ODBC Driver under flight sql subdirectory Enable Windows builds, workflow files are based on Amazon Timestream ODBC driver seed disable integration tests from running. The win-build.yml file is copied from Amazon Timestream ODBC driver code. Fix CMAKE code formats Note that rest of lint errors are not solved yet. Fix python code doc errors Enable linux build, the file is copied from Amazon Timestream ODBC seed * integration tests are disabled. * allow build scripts to be run through `chmod`. Enable macOS builds, workflow files are copied from Amazon TS ODBC seed Move Timestream ODBC driver seed under cpp/src/flightsql_odbc * Updated workflows to accommodate this change. Remove Timestream-related code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Integration Apache 2.0 licensed AWS Timestream ODBC driver into the Arrow repository.
What changes are included in this PR?
Timestream ODBC driver seed code is added under
cpp/src/arrow/flight/sql. No workflow for the driver is enabled.Are these changes tested?
Tests are not covered as tests for the driver will be added as functionalities are developed.
Are there any user-facing changes?
No.