Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/api #78

Merged
merged 3 commits into from
Aug 12, 2018
Merged

Fix/api #78

merged 3 commits into from
Aug 12, 2018

Conversation

seland
Copy link
Contributor

@seland seland commented Aug 11, 2018

Fixed several bugs in api:

@seland seland self-assigned this Aug 11, 2018
@codecov-io
Copy link

Codecov Report

Merging #78 into develop will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #78      +/-   ##
===========================================
- Coverage    57.27%   57.24%   -0.04%     
===========================================
  Files           67       67              
  Lines         3696     3698       +2     
===========================================
  Hits          2117     2117              
- Misses        1136     1138       +2     
  Partials       443      443
Impacted Files Coverage Δ
api/dapp.go 79.59% <33.33%> (-1.26%) ⬇️
dapp/request_limitation/throttling.go 32% <0%> (-4%) ⬇️
dapp/dapp.go 50% <0%> (-1.43%) ⬇️
dapp/registry/registry.go 42.6% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef8980...9bdc9d8. Read the comment docs.

Copy link
Contributor

@florianlenz florianlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @seland

@florianlenz florianlenz merged commit e58c9fc into develop Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants